Review: Needs Fixing
- Why do you use a List? Make that a SList. Even better, we know how many
subjects there are so we can just use a fixed size array or something.
- Fix the formatting: "null) {", ".append(s".
- A comment before the "return 0" explaining what happened would be nice ("//
Events with two subjects with the same URI are not supported."). Also, return a
warning so people will notice they're doing it wrong.
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fix-909708/+merge/87228
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
_______________________________________________
Mailing list: https://launchpad.net/~zeitgeist
Post to : [email protected]
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
