Review: Needs Fixing

156                  assert (event_variant.get_type_string () == "(" +
157                      Utils.SIG_EVENT + ")");

Let's turn this into assert_sig as well.

161     -            assert (iter.n_children () >= 3);

Shouldn't this throw the error as well, instead of just removing it?

-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-sig-crash/+merge/74091
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

_______________________________________________
Mailing list: https://launchpad.net/~zeitgeist
Post to     : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Reply via email to