Review: Needs Fixing

Hey,

Thanks for splitting this out :).

>    public uint32[] find_event_ids_for_clause (WhereClause where,
>                uint max_events, uint result_type,
>                BusName? sender=null) throws EngineError

This method isn't using `sender' anywhere (nor should it), so drop that 
argument.

> public WhereClause get_where_clause_for_query

Same here.
-- 
https://code.launchpad.net/~tdfischer/zeitgeist/common-where/+merge/97270
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

_______________________________________________
Mailing list: https://launchpad.net/~zeitgeist
Post to     : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Reply via email to