Review: Needs Fixing

Thanks a lot, overall it's looking very nice, I have a couple of comments 

15      +if test "x$enable_fts" = "x" ; then
16      +    enable_fts=yes
17      +fi

Looks very odd, please use the optional parameters of AC_ARG_ENABLE instead.

62      +                if (siin != null) return;

Not needed.

64      +                    "org.gnome.zeitgeist.SimpleIndexer",

Let's use INDEXER_NAME here as well.

90      +                    siin_connection_failed = true; //TODO: Is this 

Yes, it should be there.
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to