On 10/11/2010 05:19 PM, Martin Lucina wrote: > gdieth...@dcv.cl said: >>> I guess I should have reviewed your change closely, but then you >> obviously >>> didn't react to that careful comment :-) >>> >>> At this time I will also note my unhapiness with the choice that >> because >>> of >>> MSVC the version numbering now has to be manually updated in zmq.h >> itself. >>> But you insisted, so be it. >> >> How about this patch? It creates a single place where the version is >> kept; you don't have to change configure.in anymore. >> >> If there is consensus, I could push this into the master repo. > > Having an extra include file around doesn't feel right either;
Atually, Gonzalo's patch can be modified to pick the version from zmq.h. That would solve all the problems we have, no? Martin _______________________________________________ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http://lists.zeromq.org/mailman/listinfo/zeromq-dev
