Hello,
apologies if this has been reported before.

While building zeromq I noticed two lines that could use improvement:

At src/socket_base.cpp:237
replace
         generate_uuid ((unsigned char*) identity.data () + 1);
with
         generate_uuid (const_cast<unsigned char*>(identity.data ()) + 1);

(modern compilers don't like people C-casting constness away)

At src/ip.cpp:451
replace
#elif defined ZMQ_HAVE_AIX || ZMQ_HAVE_HPUX || ZMQ_HAVE_ANDROID
with
#elif defined ZMQ_HAVE_AIX || defined ZMQ_HAVE_HPUX || defined 
ZMQ_HAVE_ANDROID

(that's just a bug, and breaks the build if you have -Werror -Wundef)

Btw, I'm building 3.0.2 from same scalability tests here at the studio, 
and I noticed your website says you guys would be interested to hear 
about people stress testing zmq-3.0, it's possible in a little we could 
be one such site (as you may have read we have a few computers here). 
Feel free to get in touch with me if you think we can be useful.

HTH
Luca

-- 
Luca Fascione
Rendering Research Lead - Weta Digital
Phone:  +64  4 909 6870 (x6870)
Mobile: +64 21 0764 862

_______________________________________________
zeromq-dev mailing list
[email protected]
http://lists.zeromq.org/mailman/listinfo/zeromq-dev

Reply via email to