Would you like to make an issue for these patches? It's been very helpful when making the release notes to have an issue for every change.
Thanks a lot Pieter On Tue, Jun 5, 2012 at 6:00 PM, AJ Lewis <[email protected]> wrote: > On Tue, Jun 05, 2012 at 05:25:10PM +0200, Pieter Hintjens wrote: >> Thanks for these fixes, they're now on 3.2.x. > > Great! > >> Would you make the same PRs against libzmq? > > Working it now. > >> On Tue, Jun 5, 2012 at 4:52 PM, AJ Lewis <[email protected]> wrote: >> > 3 separate pull requests have been sent against zeromq3-x to fix these >> > issues. >> > >> > On Tue, Jun 05, 2012 at 08:57:35AM -0500, AJ Lewis wrote: >> >> Seeing issues building 3.2.0-rc1 on RHEL5, SLES11, HPUX 11iv3, and >> >> AIX7. The linux builds are failing because of a missing newline at the >> >> end of test_monitor.cpp. The hpux build is failing because a socklen_t >> >> * is getting passed in as the 3rd argument to getsockname instead of an >> >> * int *. Details below. I can open tickets in JIRA for this, but it >> >> * seemed a bit silly for the missing newline issue. >> >> >> >> It is building fine for me on RHEL6, SLES11, and Solaris. >> >> >> >> I'm seeing this on RHEL5: >> >> >> >> CXXLD test_term_endpoint >> >> CXX test_monitor.o >> >> test_monitor.cpp:125:2: error: no newline at end of file >> >> make[2]: *** [test_monitor.o] Error 1 >> >> make[2]: Leaving directory >> >> make[1]: *** [all-recursive] Error 1 >> >> make[1]: Leaving directory >> >> make: *** [compile] Error 2 >> >> [alewis@sfx11 3.2.0]$ gcc --version >> >> gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-50) >> >> Copyright (C) 2006 Free Software Foundation, Inc. >> >> This is free software; see the source for copying conditions. There is >> >> NO >> >> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR >> >> PURPOSE. >> >> >> >> And similarly on SLES10: >> >> >> >> 3 sles10_32 >> >> CXXLD test_term_endpoint >> >> CXX test_monitor.o >> >> test_monitor.cpp:125:2: error: no newline at end of file >> >> make[2]: *** [test_monitor.o] Error 1 >> >> >> >> [alewis@ajl-sles10sp4-64 3.2.0]$ gcc --version >> >> gcc (GCC) 4.1.2 20070115 (SUSE Linux) >> >> Copyright (C) 2006 Free Software Foundation, Inc. >> >> This is free software; see the source for copying conditions. There is >> >> NO >> >> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR >> >> PURPOSE. >> >> >> >> >> >> I'm also seeing build failures on HPUX 11iv3 using aCC to build: >> >> >> >> "ipc_listener.cpp", line 107: error #2167: argument of type "socklen_t >> >> *" is >> >> incompatible with parameter of type "int *" >> >> int rc = getsockname (s, (sockaddr *) &ss, &sl); >> >> ^ >> >> >> >> 1 error detected in the compilation of "ipc_listener.cpp". >> >> *** Error exit code 1 >> >> >> >> >> >> The AIX7 build fails using xlC to build with: >> >> >> >> CXX libzmq_la-device.lo >> >> "device.cpp", line 57.22: 1540-0217 (S) "rtnevents" is not a member of >> >> "struct <unnamed>". >> >> "device.cpp", line 76.22: 1540-0217 (S) "rtnevents" is not a member of >> >> "struct <unnamed>". >> >> make: 1254-004 The error code from the last command is 1. >> >> >> >> >> >> >> >> >> >> >> >> On Tue, Jun 05, 2012 at 11:18:32AM +0200, Pieter Hintjens wrote: >> >> > Hi all, >> >> > >> >> > We're pleased to announce that ZeroMQ 3.2.0 stable RC1 is now >> >> > available for download at: >> >> > >> >> > * http://download.zeromq.org/zeromq-3.2.0.tar.gz (UNIX line endings) >> >> > * http://download.zeromq.org/zeromq-3.2.0.zip (Windows line endings) >> >> > >> >> > This release is already in production and is considered highly stable. >> >> > However, as usual before upgrading to a new version with many changes, >> >> > test your apps carefully and under realistic conditions. >> >> > >> >> > A full list of changes is below. This release covers an astounding 354 >> >> > commits. Thanks to the following, who helped make this happen: >> >> > >> >> > AJ Lewis, Ben Gray, Boris Gulay, Chuck Remes, Daniel Norberg, Douglas >> >> > Young, Emmanuel Taurel, Ian Barber, Ivan Pechorin, Ivo Danihelka, Jos >> >> > Decoster, Jtzl Forshizl, Lourens Naudé, Martin Hurton, Martin Lucina, >> >> > Martin Sustrik, Mikko Koppanen, Patrick Trantham, Paul Colomiets, >> >> > Pieter Hintjens, Ricardo Catalinas Jiménez, Rob Gagnon, Sergey >> >> > Hripchenko, Max Skaller, Staffan Gimåker, Elliot Saba, and Steven >> >> > McCoy. >> >> > >> >> > -Pieter Hintjens >> >> > >> >> > >> >> > 0MQ version 3.2.0 (RC1), released on 2012/06/05 >> >> > =============================================== >> >> > >> >> > Bug fixes >> >> > --------- >> >> > >> >> > * Fixed issue 264 - Potential bug with linger, messages dropped during >> >> > socket close. >> >> > >> >> > * Fixed issue 293 - libzmq doesn't follow the ZMTP/1.0 spec (did not >> >> > set reserved bits to 0). >> >> > >> >> > * Fixed issue 303 - Assertion failure in pgm_sender.cpp:102. >> >> > >> >> > * Fixed issue 320 - Assertion failure in connect_session.cpp:96 when >> >> > connecting epgm to an invalid endpoint. >> >> > >> >> > * Fixed issue 325 - Assertion failure in xrep.cpp:93, when two sockets >> >> > connect using the same identity. >> >> > >> >> > * Fixed issue 327 - Assertion failure in mtrie.cpp:246, when >> >> > unsubscribing from channel. >> >> > >> >> > * Fixed issue 346 - Assertion failure in signaler.cpp:155, when using a >> >> > closed socket. >> >> > >> >> > * Fixed issue 328 - unsubscribe wrongly clears multiple subscriptions. >> >> > >> >> > * Fixed issue 330 - IPC listener does not remove unix domain stream file >> >> > when terminated. >> >> > >> >> > * Fixed issue 334 - Memory leak in session_base.cpp:59. >> >> > >> >> > * Fixed issue 369 - ROUTER cannot close/reopen while DEALER connected. >> >> > >> >> > >> >> > Operating systems >> >> > ----------------- >> >> > >> >> > * Fixed issue 301 - HPUX 11iv2 - build fails, CLOCK_MONOTONIC >> >> > undefined. >> >> > >> >> > * Fixed issue 324 - OS/X - build fails, ECANTROUTE undefined. >> >> > >> >> > * Fixed issue 368 - Solaris / Sun C++ - build fails, no insert method >> >> > in multimap classes. >> >> > >> >> > * Fixed issue 366 - Windows - ports not freed after crash. >> >> > >> >> > * Fixed issue 355 - Windows - build fails, MSVC solution file is out of >> >> > date. >> >> > >> >> > * Fixed issue 331 - FreeBSD 8 and 9 - getaddrinfo fails with >> >> > EAI_BADFLAGS on AI_V4MAPPED flag. >> >> > >> >> > * Fixed issue xxx - Added support for WinCE. >> >> > >> >> > >> >> > Performance >> >> > ----------- >> >> > >> >> > * Fixed issue xxx - Implemented atomic operations for ARMv7a (runs >> >> > 15-20% faster). >> >> > >> >> > >> >> > API changes >> >> > ----------- >> >> > >> >> > * Fixed issue 337 - Cleaned-up context API: >> >> > >> >> > zmq_ctx_new() - create new context (will deprecate zmq_init) >> >> > zmq_ctx_destroy() - destroy context (will deprecate zmq_term) >> >> > zmq_ctx_set() - set context property >> >> > zmq_ctx_get() - get context property >> >> > >> >> > * Fixed issue xxx - Cleaned-up message API: >> >> > >> >> > zmq_msg_send() - send a message (will deprecate zmq_sendmsg) >> >> > zmq_msg_recv() - receive a message (will deprecate zmq_recvmsg) >> >> > zmq_msg_more() - indicate whether this is final part of message >> >> > zmq_msg_get() - get message property >> >> > zmq_msg_set() - set message property >> >> > >> >> > * Fixed issue xxx - Added context monitoring API: >> >> > >> >> > zmq_ctx_set_monitor() - configure monitor callback. >> >> > >> >> > * Fixed issue xxx - Added unbind/disconnect API: >> >> > >> >> > zmq_unbind() - unbind socket. >> >> > zmq_disconnect() - disconnect socket. >> >> > >> >> > * Fixed issue xxx - Added ZMQ_TCP_ACCEPT_FILTER setsockopt() for >> >> > listening TCP sockets. >> >> > >> >> > * Fixed issue 336 - Removed sys: transport. >> >> > >> >> > * Fixed issue 333 - Added zmq_device function back to API (was removed >> >> > in 3.0). >> >> > >> >> > * Fixed issue 340 - Add support for MAX_SOCKETS to new context API. >> >> > _______________________________________________ >> >> > zeromq-dev mailing list >> >> > [email protected] >> >> > http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> >> >> >> -- >> >> AJ Lewis >> >> Software Engineer >> >> Quantum Corporation >> >> >> >> Work: 651 688-4346 >> >> >> >> ---------------------------------------------------------------------- >> >> The information contained in this transmission may be confidential. Any >> >> disclosure, copying, or further distribution of confidential information >> >> is not permitted unless such privilege is explicitly granted in writing >> >> by Quantum. Quantum reserves the right to have electronic communications, >> >> including email and attachments, sent across its networks filtered >> >> through anti virus and spam software programs and retain such messages in >> >> order to comply with applicable data security and retention requirements. >> >> Quantum is not responsible for the proper and complete transmission of >> >> the substance of this communication or for any delay in its receipt. >> >> _______________________________________________ >> >> zeromq-dev mailing list >> >> [email protected] >> >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> > >> > -- >> > AJ Lewis >> > Software Engineer >> > Quantum Corporation >> > >> > Work: 651 688-4346 >> > > > -- > AJ Lewis > Software Engineer > Quantum Corporation > > Mobile: 612 860-8068 > Work: 651 688-4346 > YahooIM: vortechs2000 > AIM: v0r73chz > MSN: [email protected] > email: [email protected] > _______________________________________________ zeromq-dev mailing list [email protected] http://lists.zeromq.org/mailman/listinfo/zeromq-dev
