Hi Ian, Thanks, but merged it in where? I cannot see the changes at https://github.com/zeromq/cppzmq.
So I am clear, what is the protocol for submitting patches? Should I be sending the patch to the list for review as well as doing a pull request or do you just want the pull request? Sending the patch to the mailing list as well would seem to be sensible so it can be reviewed, I notice there is some talk on the list about constness, I have another pull request that adds const data access to message_t that probably isn't that visible to people on the list. Regards, Richard. Richard Newton Waters Logo Principal Software Engineer [T] +44 (0) 161 946 Waters 2685 Corporation [F] +44 (0) 161 946 Floats Road 2480 Wythenshawe [W] www.waters.com Manchester [E] M23 9LZ [email protected] UK Micromass UK Limited is registered in England under No 3162904 Registered office: Floats Road, Wythenshawe, Manchester M23 9LZ From: "Ian Barber" <[email protected]> To: "ZeroMQ development list" <[email protected]> Date: 27/07/2012 04:10 PM Subject: Re: [zeromq-dev] [PATCH] [cppzmq] Add move constructor to message_t Sent by: [email protected] On Fri, Jul 27, 2012 at 8:03 AM, Pieter Hintjens <[email protected]> wrote: > Hi Richard, > > The process for contributions is described here: > http://www.zeromq.org/docs:contributing > > Basically you want to make github pull requests against the cppzmq project. Hi Pieter, He both pull reqed and send a patch. Merged it in. Ian _______________________________________________ zeromq-dev mailing list [email protected] http://lists.zeromq.org/mailman/listinfo/zeromq-dev =========================================================== The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. ===========================================================
<<inline: 70263135.gif>>
<<inline: ecblank.gif>>
<<inline: graycol.gif>>
_______________________________________________ zeromq-dev mailing list [email protected] http://lists.zeromq.org/mailman/listinfo/zeromq-dev
