Looked over things, looks good, gives the expected output and seems to work with my (admittedly rather crude :)) tests.
Cheers, Merijn On Sep 4, 2013, at 17:41 , Pieter Hintjens wrote: > I've pushed the changes, it was quite simple. > https://github.com/zeromq/libzmq/pull/645 > > > On Wed, Sep 4, 2013 at 6:03 PM, Merijn Verstraaten > <[email protected]> wrote: >> Pieter, >> >> Oh good, I was working on my own patches. Changing the wire format for the >> command frames is fairly trivial, but I wasn't really sure how to deal with >> the flags. My initial approach was to add v3_decoder/v3_encoder, but that >> resulted in quite a bit of code duplication. I was just looking into a >> better way to reuse the existing encoders/decoders, but if you're working on >> these right now I'll just leave it for now. >> >> Thanks, >> Merijn >> >> On Sep 4, 2013, at 16:18 , Pieter Hintjens wrote: >>> Merijn, >>> >>> I'm fixing the command names and flags now so that libzmq conforms to >>> the RFCs, will make a pull request soon. You can check the changes and >>> see if they match what you were doing. >>> >>> Cheers >>> Pieter >>> >>> On Wed, Sep 4, 2013 at 8:47 AM, Pieter Hintjens <[email protected]> wrote: >>>> We track issues using a Jira issue tracker, at https://zeromq.jira.com. >>>> >>>> For the command frames, this is something we didn't finish properly, >>>> we were going to do that before the 4.0 release. >>>> >>>> On Tue, Sep 3, 2013 at 11:55 PM, Merijn Verstraaten >>>> <[email protected]> wrote: >>>>> Hey, >>>>> >>>>> I was wondering where to log/report issues/bugs in HEAD. Should I open an >>>>> issue on the github issue tracker? I have some changes that get it closer >>>>> to the protocol specced in the RFCs (i.e. I fixed the command names to be >>>>> properly length prefixed), but there are some issues still left that I >>>>> don't know how to tackle (i.e. currently command frames aren't properly >>>>> tagged as such in the flags of a frame). >>>>> >>>>> Cheers, >>>>> Merijn >>>>> >>>>> _______________________________________________ >>>>> zeromq-dev mailing list >>>>> [email protected] >>>>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >>>>> >>> _______________________________________________ >>> zeromq-dev mailing list >>> [email protected] >>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> >> >> _______________________________________________ >> zeromq-dev mailing list >> [email protected] >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> > _______________________________________________ > zeromq-dev mailing list > [email protected] > http://lists.zeromq.org/mailman/listinfo/zeromq-dev
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ zeromq-dev mailing list [email protected] http://lists.zeromq.org/mailman/listinfo/zeromq-dev
