The test_many_sockets should IMO create sockets in a loop, without limit, until it receives a NULL return, and then exit happily. The goal being to check that libzmq does not crash or assert when this condition hits.
On Sat, Nov 9, 2013 at 1:19 PM, Bruno D. Rodrigues <[email protected]> wrote: > So if the limits are raised should the test fail or still pass albeit > is not testing anything? > > I don't think it's a good idea to have tests depending on > externalities as they should run consistently no matter what the > ulimits -n is (as long as it's sane), but can I assume a default of > 1024 (is it the default/minimum from Linux?), and if so I'll try to > have a look at them later. > > 1. Assume ulimits 1024? Why does the doc say 1200? > > 2. That test shall pass or fail if limits are raised? > > > > -- > Bruno Rodrigues > Sent from my iPhone > > No dia 09/11/2013, às 11:25, Pieter Hintjens <[email protected]> escreveu: > >> XFAIL is intentional failure, which is normal for the two tests that have it. >> >> The test_many_sockets test is meant to exceed system limits and check >> libzmq deals with it correctly. It shouldn't need raising process >> handles to pass. The code may still be flaky on OS/X. >> >> >> On Sat, Nov 9, 2013 at 12:18 PM, Bruno D. Rodrigues >> <[email protected]> wrote: >>> With the current master, I get all pass on macosx as long as I run ulimit >>> -n 8192 before. >>> >>> The test_many_sockets fails because it creates 5K sockets. The shutdown may >>> fail for similar reasons. >>> >>> ============================================================================ >>> Testsuite summary for zeromq 4.1.0 >>> ============================================================================ >>> # TOTAL: 46 >>> # PASS: 44 >>> # SKIP: 0 >>> # XFAIL: 2 >>> # FAIL: 0 >>> # XPASS: 0 >>> # ERROR: 0 >>> >>> (I assume the 2 XFAIL are okish?) >>> >>> >>>> On Nov 9, 2013, at 9:38, Pieter Hintjens <[email protected]> wrote: >>>> >>>>> On Sat, Nov 9, 2013 at 8:17 AM, Matt Connolly <[email protected]> >>>>> wrote: >>>>> >>>>> test_many_sockets.log: >>>>> Assertion failed: nbytes == sizeof (dummy) (signaler.cpp:149) >>>> >>>> Some unhandled error condition on line 140; presumably specific to OS/X. >>>> >>>> -Pieter >>>> _______________________________________________ >>>> zeromq-dev mailing list >>>> [email protected] >>>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >>> >>> _______________________________________________ >>> zeromq-dev mailing list >>> [email protected] >>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> >> >> >> -- >> - >> Pieter Hintjens >> CEO of iMatix.com >> Founder of ZeroMQ community >> blog: http://hintjens.com >> _______________________________________________ >> zeromq-dev mailing list >> [email protected] >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev > _______________________________________________ > zeromq-dev mailing list > [email protected] > http://lists.zeromq.org/mailman/listinfo/zeromq-dev -- - Pieter Hintjens CEO of iMatix.com Founder of ZeroMQ community blog: http://hintjens.com _______________________________________________ zeromq-dev mailing list [email protected] http://lists.zeromq.org/mailman/listinfo/zeromq-dev
