Yes, the more merges the better... :-) I wanted this to go onto master so others could play with it.
On Thu, Feb 4, 2016 at 4:36 PM, Arnaud Loonstra <[email protected]> wrote: > On 2016-02-04 15:16, Pieter Hintjens wrote: >> Hi all, >> >> I've started on a Zyre binding for Node.js. It's an experiment that >> will feed into a proper target for zproject. >> >> The code is here: https://github.com/zeromq/zyre/pull/412 >> >> (on zyre master as soon as it's merged). >> >> Pull requests welcome as usual. >> >> -Pieter > > Nice, the more bindings the better... > > Did you actually wanted it to merge as the build is failing? > > The -oneline flag in ci-build.sh I guess should be --oneline? > > I've submitted a pull request for a first fix. > > The build also fails because its out of sync with zproject: > > +git --version > git version 2.7.0 > ++git --no-pager diff -w > +[[ -n diff --git a/configure.ac b/configure.ac > index 88bfe45..75f41f0 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -514,7 +514,7 @@ fi > AC_ARG_ENABLE([drafts], > AS_HELP_STRING([--enable-drafts], > [Build and install draft classes and methods [default=yes.]]), > - [enable_drafts=$withval], > + [enable_drafts=$enableval], > [enable_drafts=$gitmaster]) > > AM_CONDITIONAL([ENABLE_DRAFTS], [test x$enable_drafts != xno]) ]] > +git --no-pager diff -w > diff --git a/configure.ac b/configure.ac > index 88bfe45..75f41f0 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -514,7 +514,7 @@ fi > AC_ARG_ENABLE([drafts], > AS_HELP_STRING([--enable-drafts], > [Build and install draft classes and methods [default=yes.]]), > - [enable_drafts=$withval], > + [enable_drafts=$enableval], > [enable_drafts=$gitmaster]) > > AM_CONDITIONAL([ENABLE_DRAFTS], [test x$enable_drafts != xno]) > +echo 'There are diffs between current code and code generated by > zproject!' > There are diffs between current code and code generated by zproject! > +exit 1 > > > Arnaud > _______________________________________________ > zeromq-dev mailing list > [email protected] > http://lists.zeromq.org/mailman/listinfo/zeromq-dev _______________________________________________ zeromq-dev mailing list [email protected] http://lists.zeromq.org/mailman/listinfo/zeromq-dev
