[
https://issues.apache.org/jira/browse/ZETACOMP-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050217#comment-13050217
]
[email protected] commented on ZETACOMP-81:
-------------------------------------------------------
bq. On 2011-06-15 12:11:33, james pic wrote:
bq. > trunk/Authentication/src/session/authentication_session.php, line 136
bq. > <https://reviews.apache.org/r/783/diff/1/?file=19578#file19578line136>
bq. >
bq. > why not use a local variable for that ? would it make the code more
readable and easier to debug ?
A local variable for time() ? If yes, then you are right, I will fix this.
- Jérôme
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/783/#review844
-----------------------------------------------------------
On 2011-05-25 08:23:39, Jérôme Renard wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/783/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-05-25 08:23:39)
bq.
bq.
bq. Review request for zetacomponents.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added a new ezcAuthenticationSessionOptions::idleTimeOut option to handle
user's inactivity.
bq.
bq.
bq. This addresses bug ZETACOMP-81.
bq. https://issues.apache.org/jira/browse/ZETACOMP-81
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/Authentication/src/options/session_options.php 1125639
bq. trunk/Authentication/src/session/authentication_session.php 1125639
bq. trunk/Authentication/tests/session/session_test.php 1125639
bq.
bq. Diff: https://reviews.apache.org/r/783/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added two new unit tests :
bq. - ezcAuthenticationSessionTest::testSessionIsValidIdleTimeout()
bq. - ezcAuthenticationSessionTest::testSessionIsValidIdleTimeoutExpired()
bq.
bq. php ./UnitTest/src/runtests.php --filter=ezcAuthenticationSessionTest
--verbose Authentication
bq. PHPUnit 3.5.10 by Sebastian Bergmann.
bq.
bq. Zeta Components:
bq.
bq. Authentication:
bq. ezcAuthenticationGeneralTest:
bq. ezcAuthenticationSessionTest: ............
bq. [...]
bq.
bq.
bq. Thanks,
bq.
bq. Jérôme
bq.
bq.
> Session timeout
> ---------------
>
> Key: ZETACOMP-81
> URL: https://issues.apache.org/jira/browse/ZETACOMP-81
> Project: Zeta Components
> Issue Type: Bug
> Components: Authentication
> Reporter: Philipp Kamps
> Attachments: patch.txt
>
>
> Not sure, but looks like the session timeout is strange. I have following
> code:
> $options = new ezcAuthenticationSessionOptions();
> $options->validity = 10;
> $session = new ezcAuthenticationSession( $options );
> I would expect a session timeout after 10 seconds __OF INACTIVITY__. But it
> looks like it's a total lifetime of 10 seconds, even when I'm active (
> constantly requesting more pages that start the session ).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
