Pawel Jakub Dawidek wrote:
> so I started to use it. The thing is that it broke some functionality.
> For example 'zpool status -v' doesn't show file names anymore.
> 
> I tracked it down to the zap_value_search() function and changing:
> 
>       if (za->za_first_integer == value) {
> into:
>       if (ZFS_DIRENT_OBJ(za->za_first_integer) == value) {

This is essentially correct, although it breaks the layering (the ZAP 
shouldn't have such intimate knowledge of the ZPL's usage).  Better 
would be to pass in a mask to zap_value_search().

But, this is certainly a bug, which I'll file shortly.

Have you found any other functionality to break when you store the file 
type in the directory entry?

--matt

Reply via email to