Pawel Jakub Dawidek wrote:
> On Tue, Jun 26, 2007 at 07:45:51AM -0700, Mark.Shellenbaum at Sun.COM wrote:
>> Author: marks
>> Repository: /hg/onnv/onnv-gate
>> Latest revision: 12bb2876a62ea4f4c1b28320f39a0d30334fdf21
>> Total changesets: 1
>> Log message:
>> PSARC/2006/465 ZFS Delegated Administration
>> PSARC/2006/577 zpool property to disable delegation
>> PSARC/2006/625 Enhancements to zpool history
>> PSARC/2007/228 ZFS delegation amendments
>> PSARC/2007/295 ZFS Delegated Administration Addendum
>> 6280676 restore "owner" property
>> 6349470 investigate non-root restore/backup
>> 6572465 'zpool set bootfs=...' records history as 'zfs set bootfs=...'
> [...]
>
> One more very minor thing. In zfs_vfsops.c you added the code below:
>
> error = dsl_deleg_access(osname, ZFS_DELEG_PERM_MOUNT, cr);
> if (error == 0) {
> vattr_t vattr;
>
> /*
> * Make sure user is the owner of the mount
> * point
> * or has sufficient privileges.
> */
>
> vattr.va_mask = AT_UID;
>
> if (VOP_GETATTR(mvp, &vattr, 0, cr)) {
> goto out;
> }
>
> if (error = secpolicy_vnode_owner(cr, vattr.va_uid)) {
> goto out;
> }
>
> if (error = VOP_ACCESS(mvp, VWRITE, 0, cr)) {
> goto out;
> }
>
> secpolicy_fs_mount_clearopts(cr, vfsp);
> } else {
> goto out;
> }
>
> In case of VOP_GETATTR() failure, error variable is not set, so we
> return success without mounting the file system. It's quite hard to makr
> VOP_GETATTR() to fail, but just for consistency...
>
>
I opened the following bug for this.
6578215 zfs_mount()needs to handle GETATTR failures better.
-Mark
