Matthew Ahrens wrote: > I just looked at your code and didn't see anything that would be causing > your bugs. I can't speak for the SPA stuff, but the rest looks good. > Here are some general comments:
Thanks for looking. > in dmu_object_info_t, you need to decrease the size of doi_pad by 1 > byte. This is so that all structure members will have the same offset > on 32 and 64 bits, so that it can be passed between a 64-bit kernel and > a 32-bit app. Fixed thanks. > in dbuf_sync(), the comment says "ZFS metadata is in the clear but ZPL > metadata should be encrypted". I assume that "ZFS metadata" means > "DMU/DSL/SPA metadata"? But it looks like you are encrypting DMU > metadata (indirect blocks -- db_level > 0), and you are not encrypting > any metadata, not even ZPL metadata like directories (from ot_metadata). Yeah I know about that, but I wanted get over the current hurdle first. > eventually, the zil's blocks will need to be encrypted as well. Yep I think I have some XXX darrenm's in the code about that :-) Thanks again for trying. Now what do I do ;-( -- Darren J Moffat
