>
> Webrev at:
>
> http://cr.grommit.com/~eschrock/zfs-prop/
>
I haven't looked at all of it, but here is what I've noticed.
zfs_main.c
Should use strlcpy() instead of strcpy() in get_callback().
What are your plans for ZFS_ABORT env variable? You should
probably remove it before putback.
libzfs_dataset.c
prop_parse_xxx functions should all check that nvpair_xxx_xxx()
functions succeed before comparing the value of "value".
I would suggest just wrapping a verify() around the nvpair_xxx_xxx()
function, since they should never fail.
Lines 283-2838 Should check that cp isn't null before setting it to
'\0'. The strchr() call could return null if '@' wasn't in the
string.
strcpy() should use strlcpy() and strcat() should use strlcat().
zfs_ioctl.c
put_nvlist() probably shouldn't set zc_nvlist_dst_size when
nvlist_pack fails.
