Nicolas Williams wrote: >>> (b) means that zfs create -o encryption=on could be interactive. I >>> think that's OK, but see below. >> I was explicitly trying to avoid making any existing command go interactive. > > As long as it only happens with new options I don't see why not. What > sort of principle applies that couldn't be excepted?
There is no new option, just a new key=value to an existing command, verb and option. The big issue I have here is I really really don't want zfs create to change behaviour from what it does now and for it to differ between the different key management styles (either the two (pool & dataset) that we are delivering for phase 1 or any future ones). However don't just think about the CLI but also how this would work in a GUI (web or local) or from some other application calling directly into libzfs that isn't the current CLI. -- Darren J Moffat
