Darren J Moffat wrote:
> Ceri Davies wrote:
>> I don't like the format of the output from "zfs get keystatus tank/izick" 
>> which is inconsistent with other output from "zfs get".
> 
> What would you like to see ?
> 
> I agree with you that multiple words isn't correct here we should 
> probably have a defined set of values:
>       available
>       unavailable
>       notdefined
> 
> and only ever return those strings.
> 

Should do these need to be real words?  If compression words into one 
like "notloaded" is fine, we could just use what we have internally.  I 
had found it not very esthetically pleasing so I hesitated on that..  We 
could just define them as undefined, notloaded, and loaded.  In the same 
syntax as it is internally...

      ZIO_CRYPT_KEY_UNDEFINED, /* Wrapping key not defined */
      ZIO_CRYPT_KEY_NOTLOADED, /* Key defined, but not loaded */
      ZIO_CRYPT_KEY_LOADED     /* Key defined and loaded */

Tony


Reply via email to