>> this seems quite easy to me.... but I don't know how to "move around" to >> actually implement/propose the required changes. >> >> >> To make grub aware of gzip (as it already is of lzjb) the steps should be: >> >> >> 1. create a new >> >> /onnv-gate/usr/src/grub/grub-0.95/stage2/zfs_gzip.c >> >> starting from >> >> /onnv-gate/usr/src/uts/common/fs/zfs/gzip.c >> >> and removing the gzip_compress funcion
Yes, but it is a little bit more complicated than that. gzip support in in-kernel ZFS leverages in-kernel zlib implementation. There is support for gzip decompression algorithm in grub (see gunzip.c), so one need to figure out how to leverage that and replace z_uncompress() with proper call. >> 2. add gzip_decompress >> >> at the end of >> >> /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.h >> >> >> 3. update the decomp_table function to link "gzip" and all "gzip-N" >> (with N=1...9) to the gzip_decompress function in >> >> /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.c This sounds reasonable. Also one need to make sure that resulting binary does not exceed size requirements (if any), thoroughly test it to verify that it works on all HW architectures with all compression algorithms (and even mix of them). This may be not an exhaustive list of things to do. >> What should I do to go on with this changes? Should I start a "community >> project"? >> > These changes look simple enough so there is no point setting up > community project imho. > > Just implement it, test it then ask for a sponsor and integrate it. As Robert points out, this indeed may be quite simple to bother setting up community project, so it may be better to treat this just like bite-size-rfe ;-) Wbr, Victor _______________________________________________ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/zfs-discuss
