Andriy Gapon writes: > on 06/12/2009 19:40 Volker A. Brandt said the following: > >> I wanted to add a disk to the tank pool to create a mirror. I accidentally > >> used zpool add ? instead of zpool attach ? and now the disk is added. Is > >> there a way to remove the disk without loosing data? > > > > Been there, done that -- at a customer site while showing off > > ZFS. :-) [...] > > Yep. My 2 cents -- 'add' and 'attach' are so similar the words that I think > that ZFS tools UI designers (if any) should re-consider naming of these > commands. Or 'add' command should always be interactive and ask for at least > two confirmations that a user knows what he is doing and why. Perhaps, it > should include a ZFS micro-exam too. > Jokes aside, this is too easy to make a mistake with the consequences that are > too hard to correct. Anyone disagrees?
I absolutely totally, like, fully agree, man! :-) There should be some interaction and maybe even a display of the new pool structure, followed for a confirmation prompt. This could be overridden with the already well-established "-f" flag. Regards -- Volker -- ------------------------------------------------------------------------ Volker A. Brandt Consulting and Support for Sun Solaris Brandt & Brandt Computer GmbH WWW: http://www.bb-c.de/~vab/ Am Wiesenpfad 6, 53340 Meckenheim Email: v...@bb-c.de Handelsregister: Amtsgericht Bonn, HRB 10513 Schuhgröße: 45 Geschäftsführer: Rainer J. H. Brandt und Volker A. Brandt _______________________________________________ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/zfs-discuss