On Fri, Mar 12, 2010 at 6:24 AM, Cheese Lee <cheese...@126.com> wrote:
> I'm working on the package request for (py)zim for Fedora. This is the review 
> request:
> https://bugzilla.redhat.com/show_bug.cgi?id=563844
>
> And I have two questions to ask:
>
> 1. The ./setup.py script installs exclusively two scripts with mode set to 
> 0644:
>    /usr/lib/python2.6/site-packages/zim/_version.py
>    /usr/lib/python2.6/site-packages/zim/_lib/xdot.py
>
>    Is this an intended result?


Maybe I don't understand the question. These are not scripts, but
module files that are used by zim. The 0644 permission seems correct
to me for module files. Only /usr/bin/zim needs to be executable.

> 2. The ./setup.py script installs an empty file:
>    /usr/share/zim/preferences.conf
>
>    What's use of this file? Is it a system-wide configure file? If so, it may 
> be preferred to install the file as something like /etc/zim.conf .
>    And if it is a configure file, it should contain some commented setting 
> instructions and/or samples, or some default settings. After all, instead of 
> leaving it empty.

Need to double check, but I think this file is packaged by mistake. I
think you can safely remove it.

Regards,

Jaap

_______________________________________________
Mailing list: https://launchpad.net/~zim-wiki
Post to     : zim-wiki@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zim-wiki
More help   : https://help.launchpad.net/ListHelp

Reply via email to