On Thu, 11 Sep 2008 21:20:51 +0200, Rob Miller <[EMAIL PROTECTED]> wrote:
> Shane Hathaway wrote:
>> Rob Miller wrote:
>>> i'm assuming from the lack of response that nobody has a problem w/  
>>> this
>>> change... if i don't hear differently within the next 24 hours or so,  
>>> i'll
>>> commit the change to the 3.8 branch and the trunk.
>>
>> The change looks harmless, but please verify it passes the ZODB tests.
>
> it does.
>
>> You should also add a test that currently fails, but passes with your
>> change; that's the best way to ensure it won't break again.  I recognize
>> that may be fairly difficult, but there are a lot of people here who
>> will answer questions.
>
> no problem, this one was easy:
>
> http://svn.zope.org/ZODB/trunk/src/ZODB/blob.py?rev=91065&view=rev

i've made another fix and extended your test a bit (in  
http://svn.zope.org/?rev=91439&view=rev) to also allow the blob to be  
opened after cloning.  i ran into this problem when trying to get  
plone.app.blob to work with versioning today, but unfortunately hadn't  
updated to the latest zodb yet -- see  
http://dev.plone.org/plone/changeset/22640.

cheers,


andi

-- 
zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED]
friedelstra├če 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.1.5.1 released! -- http://plone.org/products/plone/

_______________________________________________
For more information about ZODB, see the ZODB Wiki:
http://www.zope.org/Wikis/ZODB/

ZODB-Dev mailing list  -  ZODB-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zodb-dev

Reply via email to