-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/04/2014 06:28 AM, Godefroid Chapelle wrote:
> Le 03/02/14 20:53, Tres Seaver a écrit :
>> I
>>
>> wish you hadn't pushed that -- some of these changes are definitely
>> inappropriate on the 3.10 branch (adding an Acquisition dependency
>> is definitely wrong).
>>
>>
>> Tres.
>
> Acquisition is added as a test dependency. Any hint how to replicate
> the bug without acquisition is welcome.
Define a subclass of Persistent which emulates what Acquisition does, e.g.:
from persistent import Persistent
class Foo(Persistent):
@property
def _p_jar(self): # or whatever attribute trggers
return object()
> Which other change is inappropriate ?
Adding MANIFEST.in on a release branch seems wrong to me (I don't like
them anyway, and we *definitely* don't want to encourage
instsall-from-a-github-generated-tarball on a release branch).
Overall, these changes would have been better pushed on a separate
branch, which could then be merged into the appropriate release branches
*and* the trunk.
Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 [email protected]
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlLxJukACgkQ+gerLs4ltQ4iEwCfSMrYBnSJbm9JzTJoqeb84lWk
v2YAnRAqkPFJ5zcVscm8C4qymwSjeeQI
=OEB0
-----END PGP SIGNATURE-----
_______________________________________________
For more information about ZODB, see http://zodb.org/
ZODB-Dev mailing list - [email protected]
https://mail.zope.org/mailman/listinfo/zodb-dev
