I'm probably missing something obvious, but in zoneadmd.c, why is the pair of new lines (1428/1429) repeated at every outcome of [ if (pid == ...) ]? Why not put those two lines before the if statement and be done with it?

Is there some desire to prepare the code for future flexibility which will require different actions at those three places?

Dan Price wrote:
I'm sponsoring the following fix for Mike Gerdts:

6431807 zoneadmd should daemonize itself into a new contract

I would like to request codereview on his behalf; the review should not
take long.  Materials are at http://cr.grommit.com/~dp/6431807/

Thanks to Mike, who has worked hard on this fix.


Jeff VICTOR              Sun Microsystems            jeff.victor @ sun.com
OS Ambassador            Sr. Technical Specialist
Solaris 10 Zones FAQ:    http://www.opensolaris.org/os/community/zones/faq
zones-discuss mailing list

Reply via email to