On Mon 10 Jul 2006 at 04:12PM, Jeff Victor wrote:
> I'm probably missing something obvious, but in zoneadmd.c, why is the pair 
> of new lines (1428/1429) repeated at every outcome of [ if (pid == ...) ]?  
> Why not put those two lines before the if statement and be done with it?
> 
> Is there some desire to prepare the code for future flexibility which will 
> require different actions at those three places?

Well, I think you are right in the sense that there is a simplification
that can be done; on the other hand, you've got a fork() thrown in
there, and so it's customary to do the three-way split of the codepath.

I'll play around with it; perhaps commonizing it and adding a comment
would help.

        -dp

-- 
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
zones-discuss mailing list
zones-discuss@opensolaris.org

Reply via email to