Thanks for the review. All comments taken as is unless noted below...
Tim Knitter wrote:
> 53: Why not add this struct to libbe_priv.h where the other structs live?
Because its only used privately in be_mount.c, not anywhere else.
> 294, 2208: The comment should spell out variable names (altroot) for clarity
I think altroot is pretty well understood. Its not even used as
at 2208, but I could change altroot -> alternate root, if that's what
> 546: failed to -> failed to mount a
actually, the "failed to" just needs to be nuked.
> 547: dataset mountpoint -> dataset. Mountpoint
given the removal of the "failed to" portion, the sentence makes
sense as is.
> 575: boolean_t seems a better choice since this function only has 2 states to
> return. Also calls to this function then don't have to compare against an
Actually, I think this method (along with 525), need to be changed to
return be_errno_t so that a more accurate message can ultimately be
displayed. I'll make this adjustment.
> 702: Spell out altroot in comment; alternate root
Again, I think altroot is well understood, but sure, I can change this...
> 644,715,750... "zone_mounted_here" the "here" is ambiguous, suggest just
"here" means we mounted it here in this function, so we know we need to
unmount it before leaving, as a cleanup task. I think its more ambiguous
without the "here". IMO "zone_mounted" sounds more like a status that
the zone is currently mounted.
>> Evan Layton wrote:
>>> Hello All,
>>> We're down to the wire on the zone support changes to SNAP upgrade and are
>>> looking for code review comments. We'll be taking comments up until COB
>>> October 7th. Your comments are as always welcome and appreciated.
>>> Defect 3686 is the blocker bug that was submitted to cover this work and
>>> webrev is available at:
>>> Thank you in advance for your comments and help!
>>> caiman-discuss mailing list
>>> [EMAIL PROTECTED]
>> I will review this today, Monday October 6.
>> caiman-discuss mailing list
>> [EMAIL PROTECTED]
> caiman-discuss mailing list
> [EMAIL PROTECTED]
zones-discuss mailing list