- you might want to add the crypto libraries to the list of libraries
  to watch for breakage.  ;)

- to improve the readability of crypto_ioctl(), could you make a
  dedicated function or macro that just does translation between
  the s10 and nevada versions of crypto_get_function_list_t?

- when you make the ioctl call, i see you can do a CT_TSET.  in
  this scenario you only initialize native_param.fl_provider_id,
  and the rest of native_param is garbage.  is that ok or should
  the rest of native_param be zeroed out?


On Mon, Jun 15, 2009 at 10:39:39AM -0600, Jerry Jelinek wrote:
> I need a code review for the fix for:
> ssh dumping core on maramba
> There is a webrev at:
> http://cr.opensolaris.org/~gjelinek/webrev.crypto/
> Thanks,
> Jerry
> _______________________________________________
> zones-discuss mailing list
> zones-discuss@opensolaris.org
zones-discuss mailing list

Reply via email to