nice catch.  i put it there because of it's similarity with
zonecfg_default_privset(), but it doesn't sync with the comments above.
i've moved it to the "higher-level routines" section as you suggested.


On Mon, Oct 19, 2009 at 02:02:13PM -0700, Jordan Vaughan wrote:
> Hi Ed,
> usr/src/head/libzonecfg.h
> This isn't critical, but shouldn't zonecfg_default_brand() be declared
> somewhere other than the group of "privilege-related functions"? Perhaps
> it should go under "higher-level routines".
> Other than that, this looks good to me.
> Thanks,
> Jordan
> On 10/16/09 05:12 PM, Edward Pilatowicz wrote:
>> hey all,
>> so it seems that in opensolaris b120 i broke scratch zones with the
>> following fix:
>>      9392 native zones should fail to install on opensolaris
>> so now i've got a fix for that breakage:
>>      6889379 zoneadm mount fails on opensolaris
>> the basic problem was that a bunch of the zones code used for mounting
>> scratch zones would attempt to use the "native" brand parameters.  when i
>> removed the "native" brand i broke that code.  so now i'm fixing that
>> code by introducing the concept of a default brand.  in most places
>> where we used to hard code "native", i've changed it so that we do a
>> lookup to determine the default brand name, and then use that in place
>> of "native".  currently the default brand is defined as whatever is the
>> brand specified in /etc/zones/SUNWdefault.xml.  (which on opensolaris
>> means we default to "ipkg".)
>> thanks
>> ed
>> _______________________________________________
>> zones-discuss mailing list
zones-discuss mailing list

Reply via email to