Author: phunt Date: Thu Mar 12 00:31:30 2009 New Revision: 752726 URL: http://svn.apache.org/viewvc?rev=752726&view=rev Log: ZOOKEEPER-333. helgrind thread issues identified in mt c client code
Modified: hadoop/zookeeper/trunk/CHANGES.txt hadoop/zookeeper/trunk/src/c/src/zk_adaptor.h Modified: hadoop/zookeeper/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/CHANGES.txt?rev=752726&r1=752725&r2=752726&view=diff ============================================================================== --- hadoop/zookeeper/trunk/CHANGES.txt (original) +++ hadoop/zookeeper/trunk/CHANGES.txt Thu Mar 12 00:31:30 2009 @@ -24,7 +24,10 @@ ZOOKEEPER-281. autoreconf fails for /zookeeper-3.0.1/src/c/ (phunt) ZOOKEEPER-318. remove locking in zk_hashtable.c or add locking in -collect_keys() (chris darroch via mahadev) + collect_keys() (chris darroch via mahadev) + + ZOOKEEPER-333. helgrind thread issues identified in mt c client code + (mahadev via phunt) IMPROVEMENTS: ZOOKEEPER-308. improve the atomic broadcast performance 3x. Modified: hadoop/zookeeper/trunk/src/c/src/zk_adaptor.h URL: http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/c/src/zk_adaptor.h?rev=752726&r1=752725&r2=752726&view=diff ============================================================================== --- hadoop/zookeeper/trunk/src/c/src/zk_adaptor.h (original) +++ hadoop/zookeeper/trunk/src/c/src/zk_adaptor.h Thu Mar 12 00:31:30 2009 @@ -54,7 +54,7 @@ struct _completion_list; typedef struct _buffer_head { - struct _buffer_list *head; + struct _buffer_list *volatile head; struct _buffer_list *last; #ifdef THREADED pthread_mutex_t lock; @@ -62,7 +62,7 @@ } buffer_head_t; typedef struct _completion_head { - struct _completion_list *head; + struct _completion_list *volatile head; struct _completion_list *last; #ifdef THREADED pthread_cond_t cond;