Patrick Hunt commented on ZOOKEEPER-48:

I reviewed the patch, great to see that we are adding a test for this. ;-)

Some comments:
1) if attached patch3 supersedes patch 2 please remove 2.
2) could you add documentation for "fixupACL" method? there's quite a bit going 
on in that method and it's not really clear what the contract is.
3) line 409 (fixupacl method) logs error for "missing authenciation 
provider...", is this really an error? (no exception thrown as a result...) 
should we be notifying the client in this case (might help with client side 
debugging. Perhaps a new jira for this?
4) line 65 preprequestprocessor.java, could we log an INFO message here that 
states that acl checking is being skipped (might help w/debugging down the 

> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>                 Key: ZOOKEEPER-48
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Benjamin Reed
>         Attachments: acl-2.patch, acl_3.patch
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id 
> that was used to authenticate with ZooKeeper. Thus, an exception should be 
> raised if there are no authenticated ids present. Currently, the exception is 
> not being raised.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to