[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615546#action_12615546
 ] 

james strachan commented on ZOOKEEPER-83:
-----------------------------------------

I just took a look at the patch; basically the maven conventions are to put 
source in ${module-name}/src/main/java and tests in 
${module-name}/src/test/java and resources in src/main/resources etc.

Plus it looks like hiram's split the project into multiple maven modules. (e.g. 
so that the Java 6 JMX code is a separate module so that the core of zookeeper 
can be used on Java 5 - which is a good thing IMHO - plus separating the jute 
stuff so it can be used in development time to generate code etc). Its also 
easy to generate an uber-jar if folks want later on.

This patch looks good to me - assuming folks are happy to go the maven route 
(which many other apache projects do btw - it certainly makes it much easier 
for zookeeper to be reused by other maven projects).

If this patch gets applied I'll happily volunteer to refactor my 
recipes/protocols patch to create a zookeeper-protocols module to create a 
separate jar for higher level stuff

> Switch to using maven to build ZooKeeper
> ----------------------------------------
>
>                 Key: ZOOKEEPER-83
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: build
>            Reporter: Hiram Chirino
>            Assignee: Hiram Chirino
>         Attachments: zookeeper-mavened.tgz
>
>
> Maven is a great too for building java projects at the ASF.  It helps 
> standardize the build a bit since it's a convention oriented.
> It's dependency auto downloading would remove the need to store the 
> dependencies in svn, and it will handle many of the suggested ASF policies 
> like gpg signing of the releases and such.
> The ZooKeeper build is almost vanilla except for the jute compiler bits.  
> Things that would need to change are:
>  * re-organize the source tree a little so that it uses the maven directory 
> conventions
>  * seperate the jute bits out into seperate modules so that a maven plugin 
> can be with it
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to