Patrick Hunt updated ZOOKEEPER-82:

    Status: Open  (was: Patch Available)

After applying this patch the zkServer.sh (trunk/bin) script fails due to main 
method being removed from quorum peer. Also the javadoc in QuorumPeer is 
referencing "main" method which no longer exists - was main removed 
accidentally? main was also removed from zookeeperserver which is the 
standalone server.

I think we should document the public api methods which were added to 
zookeeperserver & quorumpeer classes.

I like your idea of moving from extending thread to implementing runnable if it 
can be done with minimal impact on existing (user) code... esp since it means 
we don't hide the previously checked exceptions as unchecked.

Note: I'm not familiar with jmx, Andrew should review the updated patch, might 
be issues there I'm not aware of, I'll add him to the watch list.

> Make the ZooKeeperServer more DI friendly
> -----------------------------------------
>                 Key: ZOOKEEPER-82
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Hiram Chirino
>            Assignee: Hiram Chirino
>         Attachments: ZOOKEEPER-82.patch
> Proposed changes were discussed in [this mailing list 
> thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL
> Basic goals are: 
> * Decouple the current configuration system from the public API.  I
> see stuff like ZooKeeperServer being coupled to ServerConfig a bit.
> * Allow the use of setter injection in addition to constructor
> injection. This is the most important thing needed to let spring more
> easily configure the objects.
> * Move the main() methods out of the ZooKeeperServer class.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to