[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-59:
----------------------------------

    Status: Open  (was: Patch Available)

Cancelling this patch due to test failure - the vm itself is crashing. Flavio, 
do the tests pass for you with this patch applied?

I'm seeing the following after applying this patch - the mainline/HEAD code is 
testing fine. This is ubuntu with java 1.6.0_06.

junit.run:
    [junit] Running org.apache.zookeeper.server.DeserializationPerfTest
    [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 15.073 sec
    [junit] Running org.apache.zookeeper.server.SerializationPerfTest
    [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 12.307 sec
    [junit] Running org.apache.zookeeper.server.ZooKeeperServerTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.141 sec
    [junit] Running org.apache.zookeeper.test.AsyncTest
    [junit] Tests run: 2, Failures: 2, Errors: 0, Time elapsed: 108.481 sec
    [junit] Test org.apache.zookeeper.test.AsyncTest FAILED
    [junit] Running org.apache.zookeeper.test.ClientTest
    [junit] Running org.apache.zookeeper.test.ClientTest
    [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
    [junit] Test org.apache.zookeeper.test.ClientTest FAILED (crashed)
    [junit] Running org.apache.zookeeper.test.DataTreeTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.15 sec
    [junit] Running org.apache.zookeeper.test.OOMTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.022 sec
    [junit] Running org.apache.zookeeper.test.QuorumTest
    [junit] Tests run: 5, Failures: 5, Errors: 0, Time elapsed: 201.057 sec
    [junit] Test org.apache.zookeeper.test.QuorumTest FAILED
    [junit] Running org.apache.zookeeper.test.RecoveryTest
    [junit] Running org.apache.zookeeper.test.RecoveryTest
    [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
    [junit] Test org.apache.zookeeper.test.RecoveryTest FAILED (crashed)
    [junit] Running org.apache.zookeeper.test.SessionTest
    [junit] Running org.apache.zookeeper.test.SessionTest
    [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
    [junit] Test org.apache.zookeeper.test.SessionTest FAILED (crashed)
    [junit] Running org.apache.zookeeper.test.WatcherFuncTest
    [junit] Running org.apache.zookeeper.test.WatcherFuncTest
    [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
    [junit] Test org.apache.zookeeper.test.WatcherFuncTest FAILED (crashed)

BUILD FAILED
/home/phunt/dev/Workspaces/gitzk/build.xml:370: Tests failed!


> Synchronized block in NIOServerCnxn
> -----------------------------------
>
>                 Key: ZOOKEEPER-59
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-59
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>         Attachments: ZOOKEEPER-59.patch
>
>
> There are two synchronized blocks locking on different objects, and to me 
> they should be guarded by the same object. Here are the parts of the code I'm 
> talking about:
> {noformat}
> [EMAIL PROTECTED]
> ...
>           synchronized (this) {
>                 outstandingRequests++;
>                 // check throttling
>                 if (zk.getInProcess() > factory.outstandingLimit) {
>                     disableRecv();
>                     // following lines should not be needed since we are 
> already
>                     // reading
>                     // } else {
>                     // enableRecv();
>                 }
>             } 
> {noformat}
> {noformat}
> [EMAIL PROTECTED]
> ...
>          synchronized (this.factory) {
>                 outstandingRequests--;
>                 // check throttling
>                 if (zk.getInProcess() < factory.outstandingLimit
>                         || outstandingRequests < 1) {
>                     sk.selector().wakeup();
>                     enableRecv();
>                 }
>             }
> {noformat}
> I think the second one is correct, and the first synchronized block should be 
> guarded by "this.factory". 
> This could be related to issue ZOOKEEPER-57, but I have no concrete 
> indication that this is the case so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to