Jakob Homan updated ZOOKEEPER-110:

    Attachment: revthrushell.diff

I've re-done the patch to use a shell script to obtain the revision number, ala 
Hadoop's approach.  This works on *nix machines, maintains functionality, 
removes the reliance on svnant (which can be deleted from the lib directory) 
and introduces no new dependencies.  

As far as Windows machines go, the operating system's poor default scripting 
environment makes this rather easy task pretty difficult.  However, it would be 
easy enough to do in MS Powershell, and I don't think it's unreasonable to 
expect developers' machines to have that tool installed at this point.  So I 
could certainly write up an equivalent script in Powershell, create another 
exec task targeted to Windows, and we'd be back to good without introducing a 
cygwin dependency (just a Powershell one).  One unknown: I don't know how ant 
would identify a Windows machine with cygwin but without Powershell.  Let me 
know if this sounds reasonable.  If so, I can explore that option.

Hope this is useful. -jg

> Build script relies on svnant, which is not compatible with subversion 1.5 
> working copies
> -----------------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-110
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>         Environment: Subversion 1.5 command line, or subclipse version 1.4.x
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: revthrushell.diff, svntask.diff
> The current build.xml ant script uses svnant to obtain the latest revision 
> number from the repo, however svnant is not compatible with subversion 1.5 
> (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build 
> fails with working copies checked out by this version.  The build fails with 
> "this version of subversion is too old, please get a newer version..."  This 
> will become more apparent as svn 1.5 trickles out; I'm using a brand new dev 
> environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather 
> quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant 
> build.
> svnant hasn't been updated in more than a year and appears to be dead, so it 
> may no longer be a viable tool for the ant build.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to