[
https://issues.apache.org/jira/browse/ZOOKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620632#action_12620632
]
Benjamin Reed commented on ZOOKEEPER-113:
-----------------------------------------
-1 This is the kind of change that makes things more convenient for the
implementors, but less convenient for the users. Since there are many more
users than implementors I don't think it is a good trade off to make.
I would like to propose instead that we do a ZooKeeperStub class that extends
ZooKeeper that we can use for testing. It can have all the methods stubbed out
so that we could override methods easily.
> ZooKeeper.java should be interface not concrete class.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-113
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-113
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Patrick Hunt
>
> I think ZooKeeper class in src/java/main should be an interface rather than a
> concrete class. Among other OO goodness this would give us more flexibility
> when implementing tests on client code. Would also require something like a
> factory to be created, which might actually work well with another JIRA we
> have which is the idea to use a URI(s) rather than a host:port combination
> when creating zookeeper clients.
> Unfortunately this would have a big impact on clients as it's not b/w
> compatible (instantiating a new client that is).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
