Mahadev konar commented on ZOOKEEPER-111:

this is a really good thing to clean up our tests to be more reliable. the 
patch looks good. comments --- 

1) In clientcnxn.java the log message is 
LOG.warn("Closing session " + sessionId, e);
can we print the session id to be in hex to be consistent.

again in close() in clientcnxn.java can we print the sessionid in hex
also there are some in zookeeper.java.

2) It would be nice to pull out the quorum starting and stopping code from the 
quorum servers and create a utility class that allows creation of n number of 
quorum servers in the tests. This is not related to this jira but would be a 
good thing to clean up. This is just a nice to have and the patch is good 
without this as well.

> significant cleanup of existing tests
> -------------------------------------
>                 Key: ZOOKEEPER-111
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-111
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>         Attachments: ZOOKEEPER-111.patch
> About to submit a patch that significantly cleans up existing tests.
> 1) removed the need for "sleep" calls in the tests, instead I monitor the 
> status of the server (using the client socket "stat" command) which provides 
> a barrier to the client test operations. I use this barrier both when 
> starting and ending the test.
> 2) also fixed a number of problems in the tests where the test itself was 
> broken.
> 3) general cleanup and some refactoring to make it easier to write new tests, 
> maintain old, and track down issues if the test does find a problem.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to