Benjamin Reed updated ZOOKEEPER-132:

    Status: Open  (was: Patch Available)

-1 I think the patch is okay except for the protocol change. We would like to 
keep int flags in the protocol, so that we can add new features without doing a 
protocol change. Could you use ordinals for getting the flag value: 

> Create Enum to replace CreateFlag in ZooKepper.create method
> ------------------------------------------------------------
>                 Key: ZOOKEEPER-132
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-132
>             Project: Zookeeper
>          Issue Type: Sub-task
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 3.0.0
>         Attachments: ZOOKEEPER-132.patch
> Replace the current named constant integer in the craete method with a 
> typesafe enum value.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to