Flavio Paiva Junqueira commented on ZOOKEEPER-118:

This piece of code seems correct. Sync should be processed along with other 
quorum operations such as create, but it does require some special code. In 
this case case, a follower saves the pending sync operations it has received 
from its clients before forwarding it to the leader. 

> findbugs flagged switch statement in followerrequestprocessor.run()
> -------------------------------------------------------------------
>                 Key: ZOOKEEPER-118
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-118
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Flavio Paiva Junqueira
> followerrequestprocessor:
> is the case statement for SYNC supposed to fall through?
>                 switch (request.type) {
>                 case OpCode.sync:
>                     zks.pendingSyncs.add(request);
>                 case OpCode.create:
> Please update the docs/code appropriately (if correct note it with comment 
> just after the sync case statement.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to