Flavio Paiva Junqueira commented on ZOOKEEPER-136:

This patch is great! It adds a FollowerSyncRequest class to represent in-flight 
sync operations, and it cleans up a bit the logic on the leader side. Now, 
there are several  modifications related to debugging messages, which don't 
seem to be always related to the problem is this jira. This is fine, though. I 
just commented because they make the patch look a lot more complex than it 
really is.

Something I'd like to understand is the functionality of matchSyncs. Why do we 
need a boolean flag to decide whether to process or not? Is this to 
differentiate the processing of sync on a leader and on a follower? In any 
case, it is probably a good idea to insert a comment  explaining.

The comment that leads the code of SyncTest.java seems to be copied from 
elsewhere. Should we remove it and replace with a more representative comment?

> sync causes hang in all followers of quorum
> -------------------------------------------
>                 Key: ZOOKEEPER-136
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Benjamin Reed
>             Fix For: 3.0.0
>         Attachments: ZOOKEEPER-136.patch
> The attached test causes all of the followers of a quorum to hang. Leader 
> continues to function correctly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to