Flavio Paiva Junqueira commented on ZOOKEEPER-193:

+1, it looks good. Just a few minor comments:

1- I'm not sure why logical and symbols show up with "amp": 
                 if (path != null && path.equals(znode))

    The same happens here:
                 List<String> list = zk.getChildren(root, true);

   It is probably some problem with the character representation, and I guess 
this is due to downloading/uploading the patch via http, but interestingly this 
is the first time I see such a problem with our patches.

2-  We can remove the following commented lines:
                +        //else mutex = new Integer(-1);

                +            //System.out.println("Process: " + 

> update java example doc to compile with latest zookeeper
> --------------------------------------------------------
>                 Key: ZOOKEEPER-193
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-193
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>         Attachments: ZOOKEEPER-193.patch, ZOOKEEPER-193.patch
> In particular the pkg structure has changed.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to