[ https://issues.apache.org/jira/browse/ZOOKEEPER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-217: ------------------------------------ Attachment: ZOOKEEPER-217.patch > we should use LOG.fatal instead of LOG.error when about to exit (in main for > example) done > the following exception does not indicate the config param in question - it > might be hard to track down what has to be changed in this case, in the other > exceptions you indicate the particular field/variable/etc... that needs to be > changed. done > why is parse changed to "throws Exception" rather than the more explicit > "throws IllegalArgumentException"? just because in quorumpeerconfig it tries to read the config file for the server id... and might throw an IOException. > specifying the usage in parse seems wrong to me: done.. > Errors in config file > --------------------- > > Key: ZOOKEEPER-217 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-217 > Project: Zookeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.0.0 > Reporter: Flavio Paiva Junqueira > Assignee: Mahadev konar > Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-217.patch, ZOOKEEPER-217.patch > > > Discussing 209 with Ben today, we thought that it would be better to have the > parse method of QuorumPeerConfig returning a boolean that indicates whether > the configuration is good or not, and let the caller decide whether to exit > or not. Currently we execute a System.exit() on QuorumPeerConfig.parse when > we have a critical configuration error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.