Mahadev konar commented on ZOOKEEPER-230:

the patch looks good except for a few nits:

- this is just a documentation bug
+        * notification checks. This impacts the amount of time to get
+        * the system up again after long partitions. Currently 6 seconds. 
this should be 60 seconds.
- the other one is 
+                            LOG.info("About to leave instance:" + 
proposedLeader + ", " + proposedZxid + ", " + self.getId() + ", " + 

we should wrap these lines around to confirm to 80 character columns. We dont 
have to be pedantic about the column length but 80-90 column is good enough i 
think. Their are a few more lines I think that are overly long and should be 
wrapped arnd.

> Improvements to FLE
> -------------------
>                 Key: ZOOKEEPER-230
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-230
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: leaderElection
>    Affects Versions: 3.0.0
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.1.0
>         Attachments: ZOOKEEPER-230.patch, ZOOKEEPER-230.patch, 
> ZOOKEEPER-230.patch, ZOOKEEPER-230.patch
> I'm about to attach a patch that implements the following modifications:
> . Currently, if a server is on leader election and doesn't receive a 
> notification for some amount of time t, then it sends a new set of 
> notifications if at least one server has delivered a message from the 
> previous set. With this patch, the amount of time a server waits for a 
> notification before sending a new set increases exponentially;
> . I have separated connecting to servers and queuing new notification 
> messages. Before they were all in the same message. The advantage is that now 
> I can tell to an instance of QuorumCnxManager to try to connect to other 
> servers without generating new notification messages;
> . I have changed the logging level of several messages on QuorumCnxManager. 
> They were "warn", but they should really be either "info" or "debug". I've 
> changed them to info.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to