Patrick Hunt updated ZOOKEEPER-259:

    Attachment: ZOOKEEPER-259.patch

This patch generally cleans up logging

1) better log level - esp wrt fatal/error/warn being used appropriately
2) better message text (esp where msg was fixmsg)

Additionally I've also:

1) in both the c and java clients I added logging of ping latency (DEBUG)
2) cleaned up the trace logging in a few places (some trace that should have
  been INFO or DEBUG)
3) sendbuffer in nioservercnxn - removed what looked like unnecessary wrap
  Be sure to review this during patch review
4) in syncrequestprocessor changed the run method to catch throwable
  rather than exception. errors could have slipped through

> cleanup the logging levels used (use the correct level) and messages generated
> ------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-259
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-259
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: c client, java client, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Minor
>             Fix For: 3.1.0
>         Attachments: ZOOKEEPER-259.patch
> Cleanup logging:
> make sure logging uses the correct level, esp error and warn
> make sure the messages are meaningful (esp fix "fixmsg" logs)

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to