Mahadev konar commented on ZOOKEEPER-214:

+1 the patch looks good... just a nit... 

 final static int enviCmd = ByteBuffer.wrap("envi".getBytes()).getInt();
+    final static int srstCmd = ByteBuffer.wrap("srst".getBytes()).getInt();
     final static ByteBuffer imok = ByteBuffer.wrap("imok".getBytes());

itll be good to add javadoc for all these vars. Ill add some javadoc and then 

> add new "stat reset" command to server admin port
> -------------------------------------------------
>                 Key: ZOOKEEPER-214
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-214
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.1.0
>         Attachments: ZOOKEEPER-214.patch
> A new command should be added to the server admin port (client port) that 
> allows users to reset the stats.
> We saw cases during troubleshooting where we would have liked to reset the 
> "min/avg/max latency" stats, but were unable to do so (short of restarting 
> the server).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to