[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667245#action_12667245
 ] 

fpj edited comment on ZOOKEEPER-16 at 1/26/09 5:46 AM:
--------------------------------------------------------------------------

I went over the patch and it looks good to me, although it is stale and I 
couldn't apply it to trunk. Also, one question I have is why you don't have to 
declare all methods in ZooKeeper.java that invoke validatePath as throwing 
IllegalArgumentException.

I'm canceling the patch for now.

(Never mind about the comment on IllegalArgumentException. I just found out the 
reason: it is an unchecked exception.)

      was (Author: fpj):
    I went over the patch and it looks good to me, although it is stale and I 
couldn't apply it to trunk. Also, one question I have is why you don't have to 
declare all methods in ZooKeeper.java that invoke validatePath as throwing 
IllegalArgumentException.

I'm canceling the patch for now.
  
> Need to do path validation
> --------------------------
>
>                 Key: ZOOKEEPER-16
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client, java client, server
>    Affects Versions: 3.0.0, 3.0.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.1.0
>
>         Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch
>
>
> Moved from SourceForge to Apache.
> http://sourceforge.net/tracker/index.php?func=detail&aid=1963141&group_id=209147&atid=1008544

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to