Mahadev konar commented on ZOOKEEPER-276:
one thing i noticed -
sorry I should have pointed this out earlier -
we should remove the @author tags.
This is just a convention that hadoop has been following (given that a file
might get changed often by different people over time)
+ * @author luca telloli */
also, their are no javadocs in the classes. I think it will be good to have
javadocs for some of the important classes in BookKeeper.
other than that I think the contribution looks good.
> Bookkeeper contribution
> Key: ZOOKEEPER-276
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-276
> Project: Zookeeper
> Issue Type: New Feature
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.1.0
> Attachments: ZOOKEEPER-276.patch
> BookKeeper is a system to reliably log streams of records. In BookKeeper,
> servers are "bookies", log streams are "ledgers", and each unit of a log (aka
> record) is a "ledger entry". BookKeeper is designed to be reliable; bookies,
> the servers that store ledgers can be byzantine, which means that some subset
> of the bookies can fail, corrupt data, discard data, but as long as there are
> enough correctly behaving servers the service as a whole behaves correctly;
> the meta data for BookKeeper is stored in ZooKeeper.
This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.