Benjamin Reed commented on ZOOKEEPER-16:

The patch looks good. there are two issues that i see:

1) we don't validate the path at the server. in some sense that is the most 
important place to do it. we need to put checks into PrepRequestProcessor and 
2) the check for C may give false positives for unicode characters. if the 
server check is in place, we can probably just make the client do the obvious 
check: c > 0x00 && c < 0x1f and then let the server catch the rest.

> Need to do path validation
> --------------------------
>                 Key: ZOOKEEPER-16
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client, java client, server
>    Affects Versions: 3.0.0, 3.0.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.1.0
>         Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch, 
> ZOOKEEPER-16.patch
> Moved from SourceForge to Apache.
> http://sourceforge.net/tracker/index.php?func=detail&aid=1963141&group_id=209147&atid=1008544

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to