[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670836#action_12670836
 ] 

Patrick Hunt commented on ZOOKEEPER-292:
----------------------------------------

Maxim, not sure what you mean by your comment feb5. When I run

make CFLAGS=-O3

results in:
gcc -DHAVE_CONFIG_H -I. -I. -I. -Iinclude -Igenerated -Wall -Werror -O3 -MT 
zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c  -fPIC -DPIC -o 
.libs/zookeeper.o

rather than: (with just "make"):

gcc -DHAVE_CONFIG_H -I. -I. -I. -Iinclude -Igenerated -Wall -Werror -g -O2 -MT 
zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c  -fPIC -DPIC -o 
.libs/zookeeper.o


so for me the build does use this value when compiling. Could you be more 
explicit?

> commit configure scripts (autotools) to svn for c projects and include in 
> release
> ---------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: c client, contrib-zkfuse
>            Reporter: Patrick Hunt
>             Fix For: 3.2.0
>
>
> We currently don't include configure scripts, just the .ac file itself. This 
> means that users are required
> to run "autoreconf; ./configure" rather than just configure.
> We should commit the configure script(s) to svn (hadoop core does this btw) 
> for our autotools based projects (currently c client api and zkfuse).
> Also these should be included in the build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to