Benjamin Reed commented on ZOOKEEPER-302:

+1 looks good. i have one small suggestion: in the early part of the patch you 
log some problem when you catch an exception, would it be good to log the 

> Quote values in JMX ObjectNames 
> --------------------------------
>                 Key: ZOOKEEPER-302
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Tom White
>         Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch
> Some characters are not allowed in ObjectName values and need quoting, see 
> http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
> This came up with IPv6 addresses which contain a colon character.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to