Benjamin Reed commented on ZOOKEEPER-317:

i think this is an extremely strict interpretation of API change. since we do 
not document them and they are not in any header file in the include directory, 
removing them from the set of exported functions by the shared library would 
not change the API.

> avoid exporting functions which may be static
> ---------------------------------------------
>                 Key: ZOOKEEPER-317
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-317
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.2.0
>            Reporter: Chris Darroch
>            Priority: Minor
>             Fix For: 4.0.0
> A number of functions in the 3.x.x C API such as add_to_list() and getImpl() 
> from zk_hashtable.c and data_result_checker() and child_result_checker() from 
> zookeeper.c could be marked static and removed from the set of exported 
> functions.
> Since this change would remove functions from the API, it should wait for 
> 4.0.0.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to